[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] memory: simple memory tree printer
From: |
Richard Henderson |
Subject: |
Re: [Qemu-devel] [PATCH] memory: simple memory tree printer |
Date: |
Wed, 14 Sep 2011 08:27:32 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:6.0.2) Gecko/20110906 Thunderbird/6.0.2 |
On 09/14/2011 08:23 AM, Avi Kivity wrote:
> On 09/14/2011 06:10 PM, Richard Henderson wrote:
>> >
>> > So the default address passed to the handler is now already relative? I
>> > think we should keep it like this for all converted devices, ie. take
>> > the chance, fix the remaining models, and drop the offset.
>>
>> It's non-zero for the isa portio conversion that I did, which
>> I thought was in Avi's tree.
>
> That's MemoryRegionPortio::offset, not MemoryRegion::offset.
No, look in isa_register_portio_list:
memory_region_init_io(region, ops, opaque, name, off_high - off_low);
memory_region_set_offset(region, start + off_low);
That last line sets MemoryRegion::offset.
r~
- [Qemu-devel] [PATCH] memory: simple memory tree printer, Blue Swirl, 2011/09/11
- Re: [Qemu-devel] [PATCH] memory: simple memory tree printer, Richard Henderson, 2011/09/12
- Re: [Qemu-devel] [PATCH] memory: simple memory tree printer, Jan Kiszka, 2011/09/12
- Re: [Qemu-devel] [PATCH] memory: simple memory tree printer, Avi Kivity, 2011/09/12
- Re: [Qemu-devel] [PATCH] memory: simple memory tree printer, Jan Kiszka, 2011/09/12
- Re: [Qemu-devel] [PATCH] memory: simple memory tree printer, Richard Henderson, 2011/09/14
- Re: [Qemu-devel] [PATCH] memory: simple memory tree printer, Avi Kivity, 2011/09/14
- Re: [Qemu-devel] [PATCH] memory: simple memory tree printer,
Richard Henderson <=
- Re: [Qemu-devel] [PATCH] memory: simple memory tree printer, Avi Kivity, 2011/09/14
- Re: [Qemu-devel] [PATCH] memory: simple memory tree printer, Richard Henderson, 2011/09/14
- Re: [Qemu-devel] [PATCH] memory: simple memory tree printer, Avi Kivity, 2011/09/14
- Re: [Qemu-devel] [PATCH] memory: simple memory tree printer, Jan Kiszka, 2011/09/14
- Re: [Qemu-devel] [PATCH] memory: simple memory tree printer, Jan Kiszka, 2011/09/14
- Re: [Qemu-devel] [PATCH] memory: simple memory tree printer, Avi Kivity, 2011/09/14
- Re: [Qemu-devel] [PATCH] memory: simple memory tree printer, Jan Kiszka, 2011/09/15
- Re: [Qemu-devel] [PATCH] memory: simple memory tree printer, Avi Kivity, 2011/09/15
- Re: [Qemu-devel] [PATCH] memory: simple memory tree printer, Jan Kiszka, 2011/09/15
- Re: [Qemu-devel] [PATCH] memory: simple memory tree printer, Avi Kivity, 2011/09/15