[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 09/12] sheepdog: move coroutine send/recv fun
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-devel] [PATCH v2 09/12] sheepdog: move coroutine send/recv function to generic code |
Date: |
Tue, 13 Sep 2011 17:36:19 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:6.0.2) Gecko/20110906 Thunderbird/6.0.2 |
Am 13.09.2011 17:16, schrieb Paolo Bonzini:
> On 09/13/2011 04:14 PM, Kevin Wolf wrote:
>>>> block/sheepdog.c | 225
>>>> ++++++------------------------------------------------
>>>> cutils.c | 103 +++++++++++++++++++++++++
>>>> qemu-common.h | 3 +
>>>> qemu-coroutine.c | 70 +++++++++++++++++
>>>> qemu-coroutine.h | 26 ++++++
>>
>> Can we move the code somewhere else? This is not core coroutine
>> infrastructure. I would suggest qemu_socket.h/qemu-sockets.c.
>
> It's not really socket-specific either (it uses recv/send only because
> of Windows brokenness---it could use read/write if it wasn't for that).
> I hoped sooner or later it could become a qemu_co_readv/writev, hence
> the choice of qemu-coroutine.c.
>
> Paolo
>
> ps: I also hope that the Earth will start spinning slower and will give
> me 32 hour days, so just tell me if you really want that outside
> qemu-coroutine.c.
Yes, I do want it outside qemu-coroutine.c.
If you prefer putting it next to qemu_write_full() and friends rather
than into the sockets file, feel free to do that.
Kevin
- Re: [Qemu-devel] [PATCH 11/12] nbd: switch to asynchronous operation, (continued)
- [Qemu-devel] [PATCH 12/12] nbd: split requests, Paolo Bonzini, 2011/09/08
- [Qemu-devel] [PATCH 09/12] sheepdog: move coroutine send/recv function to generic code, Paolo Bonzini, 2011/09/08
- Re: [Qemu-devel] [PATCH 09/12] sheepdog: move coroutine send/recv function to generic code, MORITA Kazutaka, 2011/09/09
- [Qemu-devel] [PATCH v2 09/12] sheepdog: move coroutine send/recv function to generic code, Paolo Bonzini, 2011/09/09
- Re: [Qemu-devel] [PATCH v2 09/12] sheepdog: move coroutine send/recv function to generic code, MORITA Kazutaka, 2011/09/12
- Re: [Qemu-devel] [PATCH v2 09/12] sheepdog: move coroutine send/recv function to generic code, Kevin Wolf, 2011/09/13
- Re: [Qemu-devel] [PATCH v2 09/12] sheepdog: move coroutine send/recv function to generic code, Paolo Bonzini, 2011/09/13
- Re: [Qemu-devel] [PATCH v2 09/12] sheepdog: move coroutine send/recv function to generic code,
Kevin Wolf <=
- Re: [Qemu-devel] [PATCH v2 09/12] sheepdog: move coroutine send/recv function to generic code, Paolo Bonzini, 2011/09/13
[Qemu-devel] [PATCH 10/12] block: add bdrv_co_flush support, Paolo Bonzini, 2011/09/08
[Qemu-devel] [PATCH 04/12] nbd: add support for NBD_CMD_FLUSH, Paolo Bonzini, 2011/09/08
[Qemu-devel] [PATCH 07/12] sheepdog: add coroutine_fn markers, Paolo Bonzini, 2011/09/08
[Qemu-devel] [PATCH 05/12] nbd: add support for NBD_CMD_FLAG_FUA, Paolo Bonzini, 2011/09/08
Re: [Qemu-devel] [PATCH 00/12] nbd improvements, Kevin Wolf, 2011/09/09