qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 1/4] Sparc: convert mmu_helper to trace framewor


From: Stefan Hajnoczi
Subject: Re: [Qemu-devel] [PATCH 1/4] Sparc: convert mmu_helper to trace framework
Date: Tue, 13 Sep 2011 08:59:38 +0100
User-agent: Mutt/1.5.21 (2010-09-15)

On Sun, Sep 11, 2011 at 04:41:10PM +0000, Blue Swirl wrote:
> +mmu_helper_dmiss(uint64_t address, uint64_t context) "DMISS at
> %"PRIx64" context %"PRIx64
> +mmu_helper_tfault(uint64_t address, uint64_t context) "TFAULT at
> %"PRIx64" context %"PRIx64
> +mmu_helper_tmiss(uint64_t address, uint64_t context) "TMISS at
> %"PRIx64" context %"PRIx64

>From docs/tracing.txt:

  format strings must begin and end with double quotes.  When using
  portability macros, ensure they are preceded and followed by double
  quotes:
  "value %"PRIx64""

This is a parser limitation in scripts/tracetool.  We could change it to
treat everything after the trace event arguments as the format string,
but today it explicitly looks for a pattern like ".*".

I've added this to my tracing TODO list and it should be possible to
lift the limitation soon.  For now, please make sure the format string
begins and ends with double quote.

Stefan



reply via email to

[Prev in Thread] Current Thread [Next in Thread]