Re: [Qemu-devel] [PATCH] s390: remove boot image detection to fix boot with newer kernels

[Alexander Graf]

On 07.09.2011, at 14:33, Christian Borntraeger wrote:

> On 07/09/11 13:56, Alexander Graf wrote:
>> 
>> On 06.09.2011, at 13:41, Christian Borntraeger wrote:
>> 
>>> Alex,
>>> 
>>> Newer kernels will not always have a 0dd0 (basr 13,0) at address 0x10000.
>>> (e.g. current linux-next). We must not rely on specific code at certain
>>> addresses, so lets just remove this check.
>> 
>> Is there any other sane way we can find out if the image we're loading is 
>> actually bootable? I don't want users to do qemu-system-s390x -kernel 
>> vmlinux and see it just plain fail.
> 
> No, in theory it could change arbitrarily. The vmlinux case is unfortunate
> but in the end its "shoot yourself in the foot", we just have to make sure
> that we allow a graceful exit from a looping qemu guest.

That's not the answer I'd like to hear. Can't we put a magic constant somewhere 
for newer kernel versions that would identify those and keep the basr 13,0 hack 
around for older ones?


Alex