[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v3 24/27] block: Reset buffer alignment on detach
From: |
Markus Armbruster |
Subject: |
[Qemu-devel] [PATCH v3 24/27] block: Reset buffer alignment on detach |
Date: |
Tue, 6 Sep 2011 18:58:57 +0200 |
BlockDriverState member buffer_alignment is initially 512. The device
model may set them, with bdrv_set_buffer_alignment(). If the device
model gets detached (hot unplug), the device's alignment is left
behind. Only okay because device hot unplug automatically destroys
the BlockDriverState. But that's a questionable feature, best not to
rely on it.
Signed-off-by: Markus Armbruster <address@hidden>
---
block.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/block.c b/block.c
index e986986..b006e58 100644
--- a/block.c
+++ b/block.c
@@ -788,6 +788,7 @@ void bdrv_detach_dev(BlockDriverState *bs, void *dev)
bs->dev = NULL;
bs->dev_ops = NULL;
bs->dev_opaque = NULL;
+ bs->buffer_alignment = 512;
}
/* TODO change to return DeviceState * when all users are qdevified */
--
1.7.6
- [Qemu-devel] [PATCH v3 12/27] block: Leave enforcing tray lock to device models, (continued)
- [Qemu-devel] [PATCH v3 12/27] block: Leave enforcing tray lock to device models, Markus Armbruster, 2011/09/06
- [Qemu-devel] [PATCH v3 08/27] block: Revert entanglement of bdrv_is_inserted() with tray status, Markus Armbruster, 2011/09/06
- [Qemu-devel] [PATCH v3 06/27] scsi-disk: Factor out scsi_disk_emulate_start_stop(), Markus Armbruster, 2011/09/06
- [Qemu-devel] [PATCH v3 01/27] ide: Fix ATA command READ to set ATAPI signature for CD-ROM, Markus Armbruster, 2011/09/06
- [Qemu-devel] [PATCH v3 20/27] block: Show whether the virtual tray is open in info block, Markus Armbruster, 2011/09/06
- [Qemu-devel] [PATCH v3 26/27] block: New change_media_cb() parameter load, Markus Armbruster, 2011/09/06
- [Qemu-devel] [PATCH v3 15/27] ide/atapi: Don't fail eject when tray is already open, Markus Armbruster, 2011/09/06
- [Qemu-devel] [PATCH v3 13/27] block: Drop medium lock tracking, ask device models instead, Markus Armbruster, 2011/09/06
- [Qemu-devel] [PATCH v3 24/27] block: Reset buffer alignment on detach,
Markus Armbruster <=
- [Qemu-devel] [PATCH v3 25/27] nbd: Clean up use of block_int.h, Markus Armbruster, 2011/09/06
- [Qemu-devel] [PATCH v3 23/27] block: New bdrv_set_buffer_alignment(), Markus Armbruster, 2011/09/06
- [Qemu-devel] [PATCH v3 27/27] ide/atapi scsi-disk: Make monitor eject -f, then change work, Markus Armbruster, 2011/09/06
- [Qemu-devel] [PATCH v3 18/27] block: Clean up remaining users of "removable", Markus Armbruster, 2011/09/06
- [Qemu-devel] [PATCH v3 14/27] block: Rename bdrv_set_locked() to bdrv_lock_medium(), Markus Armbruster, 2011/09/06
- Re: [Qemu-devel] [PATCH v3 00/27] Block layer cleanup & fixes, Kevin Wolf, 2011/09/08