qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] ehci: avoid string arguments in trace events


From: Gerd Hoffmann
Subject: Re: [Qemu-devel] [PATCH] ehci: avoid string arguments in trace events
Date: Mon, 05 Sep 2011 10:38:41 +0200
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.20) Gecko/20110830 Red Hat/3.1.12-2.el6_1 Thunderbird/3.1.12

On 09/03/11 17:22, Stefan Hajnoczi wrote:
String arguments are not supported by all trace backends.  This patch
replaces existing string arguments in hw/usb-ehci.c either with
individual trace events that remain human-friendly or by printing raw
addresses when there is no alternative or downside to that.

Printing raw addresses *is* a downside.

States and usbsts bits remain human-friendly since it is hard to
remember all of them.  MMIO addresses are printed raw because they would
create many individual trace events and the addresses are usually easy
to remember when debugging.

I find it hard to rememeber them. There is a reason why the code to print the names for the mmio addresses is there in the first place. I don't want to loose that.

Can't we just fix the backends instead? Replacing debug fprintf with trace points isn't going to work if tracing can't handle strings.

cheers,
  Gerd




reply via email to

[Prev in Thread] Current Thread [Next in Thread]