qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 10/14] qapi: add change-vnc-password


From: Anthony Liguori
Subject: Re: [Qemu-devel] [PATCH 10/14] qapi: add change-vnc-password
Date: Fri, 02 Sep 2011 11:08:00 -0500
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.17) Gecko/20110516 Lightning/1.0b2 Thunderbird/3.1.10

On 08/25/2011 08:33 AM, Luiz Capitulino wrote:
On Wed, 24 Aug 2011 13:43:05 -0500
Anthony Liguori<address@hidden>  wrote:

This is a new QMP only command that only changes the VNC password.

Isn't this useful in HMP too?

I think the right design goal for HMP is to minimize the number of commands since a human can only remember so much.



Signed-off-by: Anthony Liguori<address@hidden>
---
  qapi-schema.json |   13 +++++++++++++
  qmp-commands.hx  |    8 ++++++++
  qmp.c            |   11 ++++++++++-
  3 files changed, 31 insertions(+), 1 deletions(-)

diff --git a/qapi-schema.json b/qapi-schema.json
index f159d81..3b2229f 100644
--- a/qapi-schema.json
+++ b/qapi-schema.json
@@ -96,3 +96,16 @@
  { 'command': 'set-blockdev-password',
    'data': {'device': 'str', 'password': 'str'} }

+##
+# @change-vnc-password:
+#
+# Change the VNC server password.
+#
+# @target:  the new password to use with VNC authentication

The argument name is "password".

Ack.

Regards,

Anthony Liguori


+#
+# Since: 1.0
+#
+# Notes:  An empty password in this command will set the password to the empty
+#         string.  Existing clients are unaffected by executing this command.
+##
+{ 'command': 'change-vnc-password', 'data': {'password': 'str'} }
diff --git a/qmp-commands.hx b/qmp-commands.hx
index 909c778..d60f72f 100644
--- a/qmp-commands.hx
+++ b/qmp-commands.hx
@@ -868,6 +868,14 @@ Example:
  EQMP

      {
+        .name       = "change-vnc-password",
+        .args_type  = "password:s",
+        .params     = "password",
+        .help       = "set vnc password",
+        .mhandler.cmd_new = qmp_marshal_input_change_vnc_password,
+    },
+
+    {
          .name       = "set_password",
          .args_type  = "protocol:s,password:s,connected:s?",
          .params     = "protocol password action-if-connected",
diff --git a/qmp.c b/qmp.c
index 8aa9c66..f817a88 100644
--- a/qmp.c
+++ b/qmp.c
@@ -12,9 +12,11 @@
   */

  #include "qemu-common.h"
-#include "sysemu.h"
  #include "qmp-commands.h"

+#include "sysemu.h"
+#include "console.h"
+
  NameInfo *qmp_query_name(Error **errp)
  {
      NameInfo *info = g_malloc0(sizeof(*info));
@@ -26,3 +28,10 @@ NameInfo *qmp_query_name(Error **errp)

      return info;
  }
+
+void qmp_change_vnc_password(const char *password, Error **err)
+{
+    if (vnc_display_password(NULL, password)<  0) {
+        error_set(err, QERR_SET_PASSWD_FAILED);
+    }
+}






reply via email to

[Prev in Thread] Current Thread [Next in Thread]