Re: [Qemu-devel] [PATCH] virtio: Make memory barriers be memory barriers

[David Gibson]

On Thu, Sep 01, 2011 at 08:47:49AM +0200, Paolo Bonzini wrote:
> On 09/01/2011 08:09 AM, David Gibson wrote:
> >The patch defines wmb() as __sync_synchronize(), a cross platform memory
> >barrier primitive available in sufficiently recent gcc versions (gcc 4.2
> >and after?).  If we care about older gccs then this patch will need to
> >be updated with some sort of fallback.
> 
> Yes, though RHEL5's 4.1 has it backported.
> 
> >Signed-off-by: Alexey Kardashevskiy<address@hidden>
> >Signed-off-by: David Gibson<address@hidden>
> 
> It will most definitely break OpenBSD, but anyway:

Uh, why?

-- 
David Gibson                    | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au  | minimalist, thank you.  NOT _the_ _other_
                                | _way_ _around_!
http://www.ozlabs.org/~dgibson