[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [Qemu-trivial] [PATCH] sh4: Fix potential crash in debu
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [Qemu-trivial] [PATCH] sh4: Fix potential crash in debug code |
Date: |
Mon, 29 Aug 2011 12:39:57 +0100 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Wed, Jul 20, 2011 at 08:56:35PM +0200, Stefan Weil wrote:
> cppcheck reports this error:
>
> qemu/hw/sh_intc.c:390: error: Possible null pointer dereference:
> s - otherwise it is redundant to check if s is null at line 385
>
> If s were NULL, the printf() statement would crash.
> Setting braces fixes this bug.
>
> Signed-off-by: Stefan Weil <address@hidden>
> ---
> hw/sh_intc.c | 9 +++++----
> 1 files changed, 5 insertions(+), 4 deletions(-)
Thanks, applied to the trivial patches tree:
http://repo.or.cz/w/qemu/stefanha.git/shortlog/refs/heads/trivial-patches
Stefan
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [Qemu-devel] [Qemu-trivial] [PATCH] sh4: Fix potential crash in debug code,
Stefan Hajnoczi <=