[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 21/24] mcf5208: convert to memory API
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH 21/24] mcf5208: convert to memory API |
Date: |
Wed, 24 Aug 2011 12:38:37 +0100 |
On 24 August 2011 11:47, Avi Kivity <address@hidden> wrote:
> On 08/24/2011 01:35 PM, Peter Maydell wrote:
>>
>> On 24 August 2011 11:11, Avi Kivity<address@hidden> wrote:
>> > diff --git a/hw/mcf5208.c b/hw/mcf5208.c
>> > index f4d4fbd..73c6961 100644
>> > --- a/hw/mcf5208.c
>> > +++ b/hw/mcf5208.c
>> > @@ -5,6 +5,7 @@
>> > *
>> > * This code is licensed under the GPL
>> > */
>> > +#include<glib.h>
>> > #include "hw.h"
>> > #include "mcf.h"
>> > #include "qemu-timer.h"
>>
>> You shouldn't need to include glib.h here, I think? hw.h includes
>> qemu-common.h
>> which includes glib.h.
>>
>
> My preference is not to depend on indirect includes; but I can remove this
> include if it's disliked by many.
qemu-common.h says
/* we put basic includes here to avoid repeating them in device drivers */
so direct includes of system headers in hw/ files is going against
current practice. I don't feel strongly either way on the question
of direct vs indirect, but we should be consistent, and the choice
we've made is "rely on qemu-common.h".
-- PMM
- [Qemu-devel] [PATCH 17/24] dummy_m68k: convert to memory API, (continued)
- [Qemu-devel] [PATCH 17/24] dummy_m68k: convert to memory API, Avi Kivity, 2011/08/24
- [Qemu-devel] [PATCH 10/24] sysbus: add sysbus_add_memory_overlap(), Avi Kivity, 2011/08/24
- [Qemu-devel] [PATCH 11/24] integratorcp: convert to memory API (RAM/flash only), Avi Kivity, 2011/08/24
- [Qemu-devel] [PATCH 20/24] mainstone: convert to memory API, Avi Kivity, 2011/08/24
- [Qemu-devel] [PATCH 18/24] g364fb: convert to memory API, Avi Kivity, 2011/08/24
- [Qemu-devel] [PATCH 21/24] mcf5208: convert to memory API, Avi Kivity, 2011/08/24
[Qemu-devel] [PATCH 07/24] an5206: convert to memory API, Avi Kivity, 2011/08/24
[Qemu-devel] [PATCH 03/24] sysbus: add helpers to add and delete memory regions to the system bus, Avi Kivity, 2011/08/24
[Qemu-devel] [PATCH 13/24] cirrus: wrap memory update in a transaction, Avi Kivity, 2011/08/24
[Qemu-devel] [PATCH 12/24] leon3: convert to memory API, Avi Kivity, 2011/08/24
[Qemu-devel] [PATCH 24/24] milkymist: convert to memory API, Avi Kivity, 2011/08/24
[Qemu-devel] [PATCH 15/24] Makefile.hw: allow hw/ files to include glib headers, Avi Kivity, 2011/08/24
[Qemu-devel] [PATCH 04/24] pci_host: convert conf index and data ports to memory API, Avi Kivity, 2011/08/24
[Qemu-devel] [PATCH 06/24] QEMUMachine: pass address space to machine init function, Avi Kivity, 2011/08/24