|
| From: | Paolo Bonzini |
| Subject: | Re: [Qemu-devel] [PATCH 08/11] Goldfish: Added the memory logger device. |
| Date: | Mon, 22 Aug 2011 16:15:09 +0200 |
| User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:5.0) Gecko/20110707 Thunderbird/5.0 |
On 08/22/2011 01:59 PM, Stefan Hajnoczi wrote:
> + DEFINE_PROP_INT32("fd", GoldfishMemlogDevice, fd, -1),
I'm not sure these fields all need to be defined here. Why make fd a
qdev property?
I agree fd doesn't make much sense, but we may want to make it a chardev. Paolo
| [Prev in Thread] | Current Thread | [Next in Thread] |