Re: [Qemu-devel] [PATCH 6/6] tcg-arm: Make tcg_out_addi inline

[Peter Maydell]

On 20 August 2011 01:10, andrzej zaborowski <address@hidden> wrote:
> On 20 August 2011 01:51, Peter Maydell <address@hidden> wrote:
>> On 17 August 2011 22:11, Richard Henderson <address@hidden> wrote:
>>> As it's not used, fixes a compilation error.
>
> Stefan Weil submitted an identical patch a couple of weeks ago, but I
> can't see the rationale for inlining.  It seems like working around
> the warning is the only reason for this patch (?), so let's either
> remove/#if0 out the function or fix the compilation options to not
> error out on something that's not an error. (I'd prefer the latter but
> others may object)

Yeah, we could remove the function (I'd prefer that to ifdeffery).
I see malc did this for ppc/ppc64 in commits 1a2eb162414 and
c24a9c6ef94.

If we do this, for consistency we should also remove the unused
implementations in tcg/ia64 and tcg/s390.

-- PMM