Re: [Qemu-devel] [PATCH v2 5/6] vga: Use linear mapping + dirty logging in chain 4 memory access mode

[Avi Kivity]

On 08/17/2011 04:38 PM, Avi Kivity wrote:
> The mmio code has
>
>             s->plane_updated |= mask; /* only used to detect font 
> change */
>
> aren't we losing it?  we could easily recover it via dirty logging.

We can't really recover it.  So I think we need to restrict the 
optimization to graphic mode.

Is grub using text mode or graphic mode?

If it's using text mode, it may be faster to compare the font plane to a 
snapshot from the last redraw than to take an exit.

--
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.