Re: [Qemu-devel] [PATCH 05/10] dma-helpers: add dma_buf_read and dma_buf_write

[Paolo Bonzini]

On 08/11/2011 05:12 PM, Kevin Wolf wrote:
> > >  Another possibility is always completing DMA in a bottom half.  This
> > >  ensures that the callback can access the AIOCB, but it exposes an
> > >  implementation detail to the caller, so I don't like it.
>
> At least in the block layer, AIO callbacks may never be called before
> the submission function has returned. I think this makes the DMA helpers
> provide the same behaviour.
>
> But I'm not sure if the definition of the AIOCB struct isn't private to
> the block layer.

Yes, it is; I would add a getter that is specific to the DMAAIOCB.

Paolo