[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 2/2] memory: crack wide ioport accesses into smaller
From: |
Avi Kivity |
Subject: |
[Qemu-devel] [PATCH 2/2] memory: crack wide ioport accesses into smaller ones when needed |
Date: |
Thu, 11 Aug 2011 10:40:26 +0300 |
The memory API supports cracking wide accesses into narrower ones
when needed; but this was no implemented for the pio address space,
causing lsi53c895a's IO BAR to malfunction.
Fix by correctly cracking wide accesses when needed.
Signed-off-by: Avi Kivity <address@hidden>
---
memory.c | 11 +++++++++--
1 files changed, 9 insertions(+), 2 deletions(-)
diff --git a/memory.c b/memory.c
index 3c18e70..81032b6 100644
--- a/memory.c
+++ b/memory.c
@@ -400,7 +400,11 @@ static void memory_region_iorange_read(IORange *iorange,
}
return;
}
- *data = mr->ops->read(mr->opaque, offset, width);
+ *data = 0;
+ access_with_adjusted_size(offset, data, width,
+ mr->ops->impl.min_access_size,
+ mr->ops->impl.max_access_size,
+ memory_region_read_accessor, mr);
}
static void memory_region_iorange_write(IORange *iorange,
@@ -418,7 +422,10 @@ static void memory_region_iorange_write(IORange *iorange,
}
return;
}
- mr->ops->write(mr->opaque, offset, data, width);
+ access_with_adjusted_size(offset, &data, width,
+ mr->ops->impl.min_access_size,
+ mr->ops->impl.max_access_size,
+ memory_region_write_accessor, mr);
}
static const IORangeOps memory_region_iorange_ops = {
--
1.7.5.3
- [Qemu-devel] [PATCH 0/2] Fix wide ioport access cracking, Avi Kivity, 2011/08/11
- [Qemu-devel] [PATCH 2/2] memory: crack wide ioport accesses into smaller ones when needed,
Avi Kivity <=
- [Qemu-devel] [PATCH 1/2] memory: abstract cracking of write access ops into a function, Avi Kivity, 2011/08/11
- Re: [Qemu-devel] [PATCH 0/2] Fix wide ioport access cracking, Gerhard Wiesinger, 2011/08/11
- Re: [Qemu-devel] [PATCH 0/2] Fix wide ioport access cracking, Avi Kivity, 2011/08/11
- Re: [Qemu-devel] [PATCH 0/2] Fix wide ioport access cracking, Avi Kivity, 2011/08/11
- Re: [Qemu-devel] [PATCH 0/2] Fix wide ioport access cracking, Gerhard Wiesinger, 2011/08/11
- Re: [Qemu-devel] [PATCH 0/2] Fix wide ioport access cracking, Avi Kivity, 2011/08/11
- Re: [Qemu-devel] [PATCH 0/2] Fix wide ioport access cracking, Gerhard Wiesinger, 2011/08/11
- Re: [Qemu-devel] [PATCH 0/2] Fix wide ioport access cracking, Avi Kivity, 2011/08/11
- Re: [Qemu-devel] [PATCH 0/2] Fix wide ioport access cracking, Avi Kivity, 2011/08/11
- Re: [Qemu-devel] [PATCH 0/2] Fix wide ioport access cracking, Gerhard Wiesinger, 2011/08/11