Re: [Qemu-devel] [PATCH 21/24] isa: add isa_address_space()

[Avi Kivity]

On 08/10/2011 07:35 PM, Avi Kivity wrote:
> On 08/10/2011 07:26 PM, Richard Henderson wrote:
> > On 08/10/2011 09:24 AM, Richard Henderson wrote:
> > >  Of course, as far as I can see, this variable is only used by
> > >  the VGA devices.  Surely we can arrange to pass down some address
> > >  space during setup of the VGA?
> >
> > ... Which seems to be what you've done in patch 23.
> >
> > So what's the point of this patch?
>
> Okay, so I'm learning a lot and also applying that learning... a good 
> thing except that I've forgotten all about it.  Had a similar case 
> with omap_gpmc.

Well, actually reading patch 23, this one doesn't make much sense.

I'd like to let it in though.  If I spend time polishing patchsets I'll 
never get rid of ram_addr_t.

The plan is:
- convert devices
- clean up bus APIs

If I do all of the at once, it will end up in tears.

--
error compiling committee.c: too many arguments to function