[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] Introduce short names for fixed width integer t
From: |
Juan Quintela |
Subject: |
Re: [Qemu-devel] [PATCH] Introduce short names for fixed width integer types |
Date: |
Tue, 09 Aug 2011 14:39:55 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) |
Peter Maydell <address@hidden> wrote:
> On 8 August 2011 13:56, Avi Kivity <address@hidden> wrote:
>> QEMU deals with a lot of fixed width integer types; their names
>> (uint64_t etc) are clumsy to use and take up a lot of space.
>>
>> Following Linux, introduce shorter names, for example U64 for
>> uint64_t.
>
> Strongly disagree. uint64_t &c are standard types and it's
> immediately clear to a competent C programmer what they are.
> Random qemu-specific funny named types just introduces an
> unnecessary level of indirection.
>
> We only just recently managed to get rid of the nonstandard
> typenames for these from fpu/...
Agreed. And if we want to change them to be "linux-like", can we just
use the linux names? Using a name with uppercase just looks doubly
wrong on my eyes.
Later, Juan.