Re: [Qemu-devel] [PATCH 2/7] Replace VMSTOP macros with a proper QemuState type

[Avi Kivity]

On 08/08/2011 04:28 PM, Luiz Capitulino wrote:
> On Mon, 08 Aug 2011 16:27:05 +0300
> Avi Kivity<address@hidden>  wrote:
>
> >  On 08/08/2011 04:25 PM, Luiz Capitulino wrote:
> >  >  >
> >  >  >   I'm worried about the following race:
> >  >  >
> >  >  >      stop
> >  >  >      (qemu stopped for internal reason)
> >  >  >      stop comment processed
> >  >  >
> >  >  >      resume
> >  >  >
> >  >  >   The (qemu stopped for internal reason) part is lost.
> >  >
> >  >  If the "stop" you're referring to happens through vm_stop(), then no,
> >  >  it won't be lost because do_vm_stop() doesn't allow qemu to be stopped
> >  >  twice.
> >
> >  What happens then?  The user sees an error?
>
> It's ignored.

Well, then, the user won't know something happened and will happily 
resume the guest, like I outlined above.

When you ignore something in the first set, something breaks in the third.

--
error compiling committee.c: too many arguments to function