Re: [Qemu-devel] [V5 Patch 3/4]Qemu: Command "block_set" for dynamic block params change

[Supriya Kannery]

On 08/04/2011 02:02 PM, Supriya Kannery wrote:
> On 08/01/2011 09:14 PM, Anthony Liguori wrote:
> > On 08/01/2011 10:44 AM, Kevin Wolf wrote:
> > > Am 01.08.2011 17:28, schrieb Anthony Liguori:
> > > > > 2. Top-level command for each parameter (e.g. block_set_hostcache).
> > > > > Supported parameters are easily discoverable via query-commands. If
> > > > > individual block devices support different sets of parameters then
> > > > > they may have to return -ENOTSUPP.
>
> I am not able to find how "query-commands" is helping out
> to programmatically find out all the supported parameters
> of a specific command. When I tried out, "query-commands"
> is listing all the supported command names. "query-xx" is
> returning current settings related to command 'xx',
> but not any information related to supported parameters
> of 'xx'.
> Am I missing something?

ok, I got it. "query commands" is not supposed to list out
supported params for each command. Each block device parameter
setting, when implemented as separate high level command, will
get listed through query-commands. And this helps user to
identify supported block parameters that can be changed.


> > Regards,
> >
> > Anthony Liguori
> >
> > > But we don't have blockdev_add today, so whatever works for your as a
> > > temporary solution...
> > >
> > > Kevin