[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] do not call monitor_resume() from migrate_fd_pu
|
From: |
Jan Kiszka |
|
Subject: |
Re: [Qemu-devel] [PATCH] do not call monitor_resume() from migrate_fd_put_buffer() error path |
|
Date: |
Wed, 03 Aug 2011 15:22:25 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 |
On 2011-08-03 09:38, Michael Tokarev wrote:
> So, can we decide on this somehow? I don't see a code
> path where we don't call monitor_resume at the end,
> so the "intermediate" monitor_resume can be dropped.
> This way we fix real bug. If there will be other
> problem from that, it can be fixed later - this will
> mean that code path is found...
I do not see any reason for the spurious resume as well, so you may add my
Reviewed-by: Jan Kiszka <address@hidden>
>
> Should I resend the initial patch again?
May help to finally trigger the merge. Direct it to Luiz Capitulino as
the subsystem maintainer.
Jan
--
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux