[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 3/7] balloon: Simplify code flow
From: |
Amit Shah |
Subject: |
[Qemu-devel] [PATCH 3/7] balloon: Simplify code flow |
Date: |
Tue, 26 Jul 2011 14:38:13 +0530 |
Replace:
if (foo) {
...
} else {
return 0;
}
by
if (!foo) {
return 0;
}
...
Signed-off-by: Amit Shah <address@hidden>
Reviewed-by: Markus Armbruster <address@hidden>
---
balloon.c | 16 +++++++---------
1 files changed, 7 insertions(+), 9 deletions(-)
diff --git a/balloon.c b/balloon.c
index 86f629e..d40be39 100644
--- a/balloon.c
+++ b/balloon.c
@@ -42,23 +42,21 @@ void qemu_add_balloon_handler(QEMUBalloonEvent *func, void
*opaque)
static int qemu_balloon(ram_addr_t target, MonitorCompletion cb, void *opaque)
{
- if (balloon_event_fn) {
- trace_balloon_event(balloon_opaque, target);
- balloon_event_fn(balloon_opaque, target, cb, opaque);
- return 1;
- } else {
+ if (!balloon_event_fn) {
return 0;
}
+ trace_balloon_event(balloon_opaque, target);
+ balloon_event_fn(balloon_opaque, target, cb, opaque);
+ return 1;
}
static int qemu_balloon_status(MonitorCompletion cb, void *opaque)
{
- if (balloon_event_fn) {
- balloon_event_fn(balloon_opaque, 0, cb, opaque);
- return 1;
- } else {
+ if (!balloon_event_fn) {
return 0;
}
+ balloon_event_fn(balloon_opaque, 0, cb, opaque);
+ return 1;
}
static void print_balloon_stat(const char *key, QObject *obj, void *opaque)
--
1.7.6
- [Qemu-devel] [PULL 0/7] virtio-balloon: cleanups, fix segfault from use-after-free, Amit Shah, 2011/07/26
- [Qemu-devel] [PATCH 1/7] balloon: Make functions, local vars static, Amit Shah, 2011/07/26
- [Qemu-devel] [PATCH 2/7] balloon: Add braces around if statements, Amit Shah, 2011/07/26
- [Qemu-devel] [PATCH 3/7] balloon: Simplify code flow,
Amit Shah <=
- [Qemu-devel] [PATCH 4/7] virtio-balloon: Separate status handling into separate function, Amit Shah, 2011/07/26
- [Qemu-devel] [PATCH 5/7] balloon: Separate out stat and balloon handling, Amit Shah, 2011/07/26
- [Qemu-devel] [PATCH 6/7] balloon: Fix header comment; add Copyright, Amit Shah, 2011/07/26
- [Qemu-devel] [PATCH 7/7] virtio-balloon: Fix header comment; add Copyright, Amit Shah, 2011/07/26