Re: [Qemu-devel] [PATCH] Bugfixes for interrupt numbering in XICS code

[David Gibson]

On Tue, Jul 26, 2011 at 10:19:36AM +1000, David Gibson wrote:
> The implementation of the XICS interrupt controller contains several
> (difficult to trigger) bugs due to the fact that we were not 100%
> consistent with which irq numbering we used.  In most places, global
> numbers were used as handled by the presentation layer, however a few
> functions took "local" numberings, that is the source number within
> the interrupt source controller which is offset from the global
> number.  In most cases the function and its caller agreed on this, but
> in a few cases it didn't.
> 
> This patch cleans this up by always using global numbering.
> Translation to the local number is now always and only done when we
> look up the individual interrupt source state structure.  This should
> remove the existing bugs and with luck reduce the chances of
> re-introducing such bugs.
> 
> Signed-off-by: David Gibson <address@hidden>

Ugh.  Disregard, the bugfix has a bug, sorry.

-- 
David Gibson                    | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au  | minimalist, thank you.  NOT _the_ _other_
                                | _way_ _around_!
http://www.ozlabs.org/~dgibson