Am 25.07.2011 um 12:09 schrieb Alexander Graf:
On 24.07.2011, at 21:08, Hervé Poussineau wrote:
+CPUPPCState *cpu_ppc_init(const char *cpu_model)
+{
+ CPUPPCState *env;
+
+ env = qemu_mallocz(sizeof(CPUPPCState));
+ if (cpu_ppc_init_inplace(env, cpu_model) < 0) {
Why would we need this function again if the CPUs are qdev'ified?
This function is not added ; it is already an existing one (see 25 lines before). I kept it to not put in the same patch the CPU qdev'ification and the change of all the callers.
Indeed, a second patch may be created to change all callers to use cpu_ppc_create_simple() and to remove this function.
Ah, I see. Please write up a patch set that goes through the bits of fully converting it to Qdev :)
Could you please consider pulling my more recent patch of a PReP-local static function for shared CPU initialization into ppc-next? That way we can share code between PReP machines now and easily convert it in one central place when CPU qdev'ification has been completed.