[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [RFC v5 82/86] sysbus: remove sysbus_init_mmio_cb()
From: |
Avi Kivity |
Subject: |
[Qemu-devel] [RFC v5 82/86] sysbus: remove sysbus_init_mmio_cb() |
Date: |
Wed, 20 Jul 2011 19:50:32 +0300 |
This problem with this function is that it is not reversible - it is
impossible to know where things are registered and unregister them
exactly. As there are no more users, we can remove it.
Signed-off-by: Avi Kivity <address@hidden>
---
hw/sysbus.c | 12 ------------
hw/sysbus.h | 2 --
2 files changed, 0 insertions(+), 14 deletions(-)
diff --git a/hw/sysbus.c b/hw/sysbus.c
index 64749e0..87221df 100644
--- a/hw/sysbus.c
+++ b/hw/sysbus.c
@@ -107,18 +107,6 @@ void sysbus_init_mmio(SysBusDevice *dev,
target_phys_addr_t size,
dev->mmio[n].iofunc = iofunc;
}
-void sysbus_init_mmio_cb(SysBusDevice *dev, target_phys_addr_t size,
- mmio_mapfunc cb)
-{
- int n;
-
- assert(dev->num_mmio < QDEV_MAX_MMIO);
- n = dev->num_mmio++;
- dev->mmio[n].addr = -1;
- dev->mmio[n].size = size;
- dev->mmio[n].cb = cb;
-}
-
void sysbus_init_mmio_cb2(SysBusDevice *dev,
mmio_mapfunc cb, mmio_mapfunc unmap)
{
diff --git a/hw/sysbus.h b/hw/sysbus.h
index 16fd969..b87c6c5 100644
--- a/hw/sysbus.h
+++ b/hw/sysbus.h
@@ -47,8 +47,6 @@ void sysbus_register_withprop(SysBusDeviceInfo *info);
void *sysbus_new(void);
void sysbus_init_mmio(SysBusDevice *dev, target_phys_addr_t size,
ram_addr_t iofunc);
-void sysbus_init_mmio_cb(SysBusDevice *dev, target_phys_addr_t size,
- mmio_mapfunc cb);
void sysbus_init_mmio_cb2(SysBusDevice *dev,
mmio_mapfunc cb, mmio_mapfunc unmap);
void sysbus_init_mmio_region(SysBusDevice *dev, MemoryRegion *memory);
--
1.7.5.3
Re: [Qemu-devel] [RFC v5 86/86] 440fx: fix PAM, PCI holes, Eric Northup, 2011/07/25
[Qemu-devel] [RFC v5 11/86] memory: add backward compatibility for old mmio registration, Avi Kivity, 2011/07/20
[Qemu-devel] [RFC v5 77/86] sysbus: add a variant of sysbus_init_mmio_cb with an unmap callback, Avi Kivity, 2011/07/20
[Qemu-devel] [RFC v5 37/86] e1000: convert to memory API, Avi Kivity, 2011/07/20
[Qemu-devel] [RFC v5 02/86] Hierarchical memory region API, Avi Kivity, 2011/07/20
[Qemu-devel] [RFC v5 41/86] ivshmem: convert to memory API, Avi Kivity, 2011/07/20
[Qemu-devel] [RFC v5 82/86] sysbus: remove sysbus_init_mmio_cb(),
Avi Kivity <=
[Qemu-devel] [RFC v5 70/86] tusb6010: move declarations to new file tusb6010.h, Avi Kivity, 2011/07/20
[Qemu-devel] [RFC v5 17/86] pc: convert pc_memory_init() to memory API, Avi Kivity, 2011/07/20
[Qemu-devel] [RFC v5 07/86] memory: rename MemoryRegion::has_ram_addr to ::terminates, Avi Kivity, 2011/07/20
[Qemu-devel] [RFC v5 48/86] pcnet: convert to memory API, Avi Kivity, 2011/07/20
[Qemu-devel] [RFC v5 09/86] memory: I/O address space support, Avi Kivity, 2011/07/20
[Qemu-devel] [RFC v5 43/86] ahci: convert to memory API, Avi Kivity, 2011/07/20
[Qemu-devel] [RFC v5 56/86] pci: remove pci_register_bar_simple(), Avi Kivity, 2011/07/20
[Qemu-devel] [RFC v5 28/86] cirrus: simplify vga window mmio access functions, Avi Kivity, 2011/07/20
[Qemu-devel] [RFC v5 47/86] ne2000: convert to memory API, Avi Kivity, 2011/07/20
[Qemu-devel] [RFC v5 58/86] pci: remove pci_register_bar(), Avi Kivity, 2011/07/20