Re: [Qemu-devel] [PATCHv3] qxl-render/qxl: split out qxl_save_ppm

[Luiz Capitulino]

On Wed, 13 Jul 2011 12:41:48 +0200
Gerd Hoffmann <address@hidden> wrote:

> On 07/13/11 11:29, Alon Levy wrote:
> > On Wed, Jul 13, 2011 at 09:10:19AM +0200, Gerd Hoffmann wrote:
> >> On 07/12/11 15:55, Alon Levy wrote:
> >>> Later the save will happen asynchronously on surface_updated callback.
> >>
> >> Hmm.  I can see why you are doing that.  It makes the file being
> >> written *after* the monitor command finishes though, which I think
> >> we should avoid.
> >
> > I think the simplest thing would be to add a specific cond for this - 
> > ppm_save_filename_cond. ok?
> 
> Not sure.  Luiz, do we have async monitor commands meanwhile?

Not yet, this is a QAPI feature that should land soon, but it's not
available yet.

> 
> Background: screendump for qxl vga can take a while as the spice-server 
> might have to render everything first ...
> 
> cheers,
>    Gerd
>