[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCHv3] qxl: qxl_send_events: ignore if stopped (instead
From: |
Alon Levy |
Subject: |
[Qemu-devel] [PATCHv3] qxl: qxl_send_events: ignore if stopped (instead of abort) |
Date: |
Tue, 12 Jul 2011 16:55:30 +0300 |
This can happen if there is an interface_get_command issued when
the server has been stopped. easy to trigger - do stop/cont a few
times (three seem to be enough).
The "solution" of ignoring the request is bad, but better then aborting
and a real solution would probably be in spice to not call get_command
in the first place.
---
hw/qxl.c | 5 ++++-
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/hw/qxl.c b/hw/qxl.c
index 8a9463e..0585f02 100644
--- a/hw/qxl.c
+++ b/hw/qxl.c
@@ -1406,7 +1406,10 @@ static void qxl_send_events(PCIQXLDevice *d, uint32_t
events)
uint32_t old_pending;
uint32_t le_events = cpu_to_le32(events);
- assert(d->ssd.running);
+ if (!d->ssd.running) {
+ fprintf(stderr, "qxl: not sending interrupt %d while stopped\n",
events);
+ return;
+ }
old_pending = __sync_fetch_and_or(&d->ram->int_pending, le_events);
if ((old_pending & le_events) == le_events) {
return;
--
1.7.6
- Re: [Qemu-devel] [PATCHv3] qxl-render/qxl: split out qxl_save_ppm, (continued)
- [Qemu-devel] [PATCHv3] qxl: add io_port_to_string, Alon Levy, 2011/07/12
- [Qemu-devel] [PATCHv3] qxl: QXL_IO_UPDATE_AREA: pass ram->update_area directly to update_area, Alon Levy, 2011/07/12
- [Qemu-devel] [PATCHv3] qxl-render: split out qxl_render_update_dirty_rectangles, Alon Levy, 2011/07/12
- [Qemu-devel] [PATCHv3] spice/qxl: move worker wrappers, Alon Levy, 2011/07/12
- [Qemu-devel] [PATCHv3] qxl: async io support using new spice api, Alon Levy, 2011/07/12
- [Qemu-devel] [PATCHv3] qxl: use QXL_REVISION_*, Alon Levy, 2011/07/12
- [Qemu-devel] [PATCHv3] qxl-render: qxl_render_update: nop if \!ssd.running, Alon Levy, 2011/07/12
- [Qemu-devel] [PATCHv3] qxl: qxl_send_events: ignore if stopped (instead of abort),
Alon Levy <=
- [Qemu-devel] [PATCHv3] qxl-render: use update_area_async and update_area_complete, Alon Levy, 2011/07/12
- [Qemu-devel] [PATCHv3] qxl: only disallow specific io's in vga mode, Alon Levy, 2011/07/12
- [Qemu-devel] [PATCHv3] qxl: add QXL_IO_FLUSH_{SURFACES, RELEASE} for guest S3&S4 support, Alon Levy, 2011/07/12
- Re: [Qemu-devel] [PATCHv3] async + suspend reworked, Gerd Hoffmann, 2011/07/13