|
From: | Anthony Liguori |
Subject: | Re: [Qemu-devel] [RFC v3 31/56] ac97: convert to memory API |
Date: | Sun, 10 Jul 2011 20:42:05 -0500 |
User-agent: | Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.17) Gecko/20110516 Lightning/1.0b2 Thunderbird/3.1.10 |
On 07/10/2011 03:33 PM, malc wrote:
On Sun, 10 Jul 2011, Avi Kivity wrote:fixes BAR sizing as well.I find this patch disgusting, the read and write handlers in particular.
Shouldn't it be possible to do something like: typedef struct OldMemoryRegionOps { MemoryRegionOps parent_ops; CPUReadMemoryFunc *readfn[3]; CPUWriteMemoryFunc *writefn[3]; void *opaque; } OldMemoryRegionOps;That should allow old-style implementations to be converted without introducing trampoline functions everywhere.
Regards, Anthony Liguori
[..snip..]
[Prev in Thread] | Current Thread | [Next in Thread] |