[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] qxl: move qemu_spice_add_memslot call out of qx
From: |
Alon Levy |
Subject: |
Re: [Qemu-devel] [PATCH] qxl: move qemu_spice_add_memslot call out of qxl_add_memslot |
Date: |
Thu, 7 Jul 2011 10:45:19 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Thu, Jul 07, 2011 at 09:39:34AM +0200, Gerd Hoffmann wrote:
> Hi,
>
> >-static void qxl_add_memslot(PCIQXLDevice *d, uint32_t slot_id, uint64_t
> >delta)
> >+static void qxl_add_memslot(PCIQXLDevice *d, uint32_t slot_id, uint64_t
> >delta,
> >+ QXLDevMemSlot *memslot)
>
> >- qxl_add_memslot(d, val, 0);
> >+ qxl_add_memslot(d, val, 0,&memslot);
> >+ qemu_spice_add_memslot(&d->ssd,&memslot);
>
> Do we still need this and the simliar patches? Given that we don't
> call qemu_spice_add_memslot() from another thread any more we could
> just pass in a async flag to qxl_add_memslot().
I will. The most changes needed are to split the part after calling worker to a
complete call,
I'm storing the io data inside PCIQXLDevice.
>
> cheers,
> Gerd
>
>
- [Qemu-devel] [PATCH] spice: add qemu_spice_display_init_common, (continued)
- [Qemu-devel] [PATCH] spice: add qemu_spice_display_init_common, Alon Levy, 2011/07/06
- [Qemu-devel] [PATCH] spice: lock spice worker calls, Alon Levy, 2011/07/06
- [Qemu-devel] [PATCH] spice: add worker wrapper functions., Alon Levy, 2011/07/06
- [Qemu-devel] [PATCH] qxl: move qemu_spice_create_primary_surface call out of qxl_create_guest_primary, Alon Levy, 2011/07/06
- [Qemu-devel] [PATCH] qxl: remove qxl_destroy_primary(), Alon Levy, 2011/07/06
- [Qemu-devel] [PATCH] spice/qxl: move worker wrappers, Alon Levy, 2011/07/06
- [Qemu-devel] [PATCH] qxl: move qemu_spice_add_memslot call out of qxl_add_memslot, Alon Levy, 2011/07/06
- [Qemu-devel] [PATCH] qxl: fix surface tracking & locking, Alon Levy, 2011/07/06
- [Qemu-devel] [PATCH] qxl: add io_port_to_string, Alon Levy, 2011/07/06
- [Qemu-devel] [PATCH] qxl: bump pci rev, Alon Levy, 2011/07/06
- [Qemu-devel] [PATCH] qxl: error handling fixes and cleanups., Alon Levy, 2011/07/06
- [Qemu-devel] [PATCH] qxl: make qxl_guest_bug take variable arguments, Alon Levy, 2011/07/06
- [Qemu-devel] [PATCH] qxl: only disallow specific io's in vga mode, Alon Levy, 2011/07/06
- [Qemu-devel] [PATCH] qxl: async I/O, Alon Levy, 2011/07/06
- [Qemu-devel] [PATCH] qxl: use QXL_REVISION_*, Alon Levy, 2011/07/06