[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] pci: add standard bridge device
|
From: |
Michael S. Tsirkin |
|
Subject: |
Re: [Qemu-devel] [PATCH] pci: add standard bridge device |
|
Date: |
Tue, 5 Jul 2011 16:43:11 +0300 |
|
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Tue, Jul 05, 2011 at 10:29:36PM +0900, Isaku Yamahata wrote:
> On Mon, Jul 04, 2011 at 12:43:59PM +0300, Michael S. Tsirkin wrote:
> > +/* Mapping mandated by PCI-to-PCI Bridge architecture specification,
> > + * revision 1.2 */
> > +/* Table 9-1: Interrupt Binding for Devices Behind a Bridge */
> > +static int pci_bridge_dev_map_irq_fn(PCIDevice *dev, int irq_num)
> > +{
> > + return (irq_num + PCI_SLOT(dev->devfn) + irq_num) % PCI_NUM_PINS;
> ^^^^^^^ ^^^^^^^
> Typo. There are 2 irq_num.
Good catch, thanks.
> --
> yamahata