Re: [Qemu-devel] [PATCH resend] vl.c: Don't limit node count by smp count

[Andre Przywara]

On 06/30/2011 05:29 AM, Sasha Levin wrote:
> [I've sent this patch couple of months ago and noticed it
>   didn't make it's way in - so I'm sending it again]
>
> It is possible to create CPU-less NUMA nodes, node amount shouldn't be
> limited by amount of CPUs.
>
> Tested-by: Michael Roth<address@hidden>
> Signed-off-by: Sasha Levin<address@hidden>
> ---
>   vl.c |    4 ++--
>   1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/vl.c b/vl.c
> index e0191e1..b95ae8d 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -3147,8 +3147,8 @@ int main(int argc, char **argv, char **envp)
>       if (nb_numa_nodes>  0) {
>           int i;
>
> -        if (nb_numa_nodes>  smp_cpus) {
> -            nb_numa_nodes = smp_cpus;
> +        if (nb_numa_nodes>  MAX_NODES) {
> +            nb_numa_nodes = MAX_NODES;
>           }
>
>           /* If no memory size if given for any node, assume the default case

Acked-by: Andre Przywara <address@hidden>

Regards,
Andre.


--
Andre Przywara
AMD-Operating System Research Center (OSRC), Dresden, Germany