[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 0/4] A few cleanups of qdev users
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH 0/4] A few cleanups of qdev users |
Date: |
Mon, 27 Jun 2011 14:36:11 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) |
Amit Shah <address@hidden> writes:
> On (Fri) 24 Jun 2011 [13:57:28], Markus Armbruster wrote:
>> Ping?
>
> There were a couple of things:
>
>> port 0, guest on, host off, throttle off
>
> guest on/off, host on/off doesn't convey much -- what's on/off?
>
> Also, 'throttle' could be 'thottled'?
Discussion petered out with my message[*]:
I chose on/off to stay consistent with how qdev shows bool
properties (print_bit() in qdev-properties.c). May be misguided.
Like you, I'm having difficulties coming up with a better version
that is still consise.
But: should "info qtree" show such device state? It's about
configuration of the device tree, isn't it? Connection status is
useful to know, but it's not device configuration. Other
print_dev() methods may cross that line, too. For instance,
usb_bus_dev_print() prints attached, which looks suspicious (commit
66a6593a).
Should info qtree continue to show this information? If yes, care to
suggest a better format?
[*] http://lists.gnu.org/archive/html/qemu-devel/2011-05/msg01919.html