[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 0/3] kvm:showing a splash picture when start
From: |
Jan Kiszka |
Subject: |
Re: [Qemu-devel] [PATCH v2 0/3] kvm:showing a splash picture when start |
Date: |
Thu, 23 Jun 2011 12:03:23 +0200 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 |
On 2011-06-23 11:18, Wayne Xia wrote:
> Hi,
> these 3 patch simply enable qemu-kvm to show a logo picture when it
You are posting on qemu-devel (which is correct for this topic), so your
patches must target that tree. Patch 1 eg. does not and needs rebasing.
> s start up, following is how to configurate it:
> invoke it with params:
> -boot (splash_time=<N>,) (splash_filename=<N>,)
Simply 'splash' for specifying the file should suffice.
> the splash_time is in the unit of ms, and its max value is 65535.
> this feature is by default on with 5000ms showing up.
Strong NAK for making this default. We have a nice sub-second BIOS time
in QEMU, and that must not be destroyed by eye candy. 5 s is also way
too long even when you want splash.
> Patch 1 contains the source modification for qemu-kvm, Patch 2 and
> 3 are binary patches that added a default logo picture file, alternated
> the bios.bin to make the sea-bios showing it. Patch 3 is just used to
> provide a convenient way to test the Patch, waiting for newer version
> of seabios that provide the support officially.
> Any comments would be very nice.
- commit logs a missing in the individual patches
- the BIOS is updated via submodule reference, and that only to SeaBIOS
releases (IOW,
you can only provide a test image so far, no patch)
- a default logo should not mention KVM but QEMU (splash is not limited
to KVM mode)
Jan
signature.asc
Description: OpenPGP digital signature
Re: [Qemu-devel] [PATCH v2 0/3] kvm:showing a splash picture when start, Wayne Xia, 2011/06/23