[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 17/18] linux-user/signal.c: Remove unused fenab
From: |
riku . voipio |
Subject: |
[Qemu-devel] [PATCH 17/18] linux-user/signal.c: Remove unused fenab |
Date: |
Mon, 20 Jun 2011 19:20:22 +0300 |
From: Peter Maydell <address@hidden>
Remove fenab as it is only written, never used. Add a FIXME
comment about the discrepancy between our behaviour and that
of the Linux kernel for this routine.
Signed-off-by: Peter Maydell <address@hidden>
Signed-off-by: Riku Voipio <address@hidden>
---
linux-user/signal.c | 7 +++++--
1 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/linux-user/signal.c b/linux-user/signal.c
index 4edd974..7d168e1 100644
--- a/linux-user/signal.c
+++ b/linux-user/signal.c
@@ -2228,7 +2228,6 @@ void sparc64_set_context(CPUSPARCState *env)
target_mc_gregset_t *grp;
abi_ulong pc, npc, tstate;
abi_ulong fp, i7, w_addr;
- unsigned char fenab;
int err;
unsigned int i;
@@ -2293,7 +2292,11 @@ void sparc64_set_context(CPUSPARCState *env)
if (put_user(i7, w_addr + offsetof(struct target_reg_window, ins[7]),
abi_ulong) != 0)
goto do_sigsegv;
- err |= __get_user(fenab, &(ucp->tuc_mcontext.mc_fpregs.mcfpu_enab));
+ /* FIXME this does not match how the kernel handles the FPU in
+ * its sparc64_set_context implementation. In particular the FPU
+ * is only restored if fenab is non-zero in:
+ * __get_user(fenab, &(ucp->tuc_mcontext.mc_fpregs.mcfpu_enab));
+ */
err |= __get_user(env->fprs, &(ucp->tuc_mcontext.mc_fpregs.mcfpu_fprs));
{
uint32_t *src, *dst;
--
1.7.4.1
- [Qemu-devel] [PATCH 08/18] linux-user: add pselect6 syscall support, (continued)
- [Qemu-devel] [PATCH 08/18] linux-user: add pselect6 syscall support, riku . voipio, 2011/06/20
- [Qemu-devel] [PATCH 09/18] linux-user: Define AT_RANDOM to support target stack protection mechanism., riku . voipio, 2011/06/20
- [Qemu-devel] [PATCH 10/18] linuxload: id_change was a write only variable, riku . voipio, 2011/06/20
- [Qemu-devel] [PATCH 11/18] syscall: really return ret code, riku . voipio, 2011/06/20
- [Qemu-devel] [PATCH 12/18] linux-user: syscall should use sanitized arg1, riku . voipio, 2011/06/20
- [Qemu-devel] [PATCH 13/18] flatload: end_code was only used in a debug message, riku . voipio, 2011/06/20
- [Qemu-devel] [PATCH 14/18] flatload: memp was a write-only variable, riku . voipio, 2011/06/20
- [Qemu-devel] [PATCH 15/18] linux-user: Bump do_syscall() up to 8 syscall arguments, riku . voipio, 2011/06/20
- [Qemu-devel] [PATCH 16/18] linux-user/signal.c: Remove only-ever-set variable fpu_save_addr, riku . voipio, 2011/06/20
- [Qemu-devel] [PATCH 17/18] linux-user/signal.c: Remove unused fenab,
riku . voipio <=
- [Qemu-devel] [PATCH 18/18] linux-user: Fix sync_file_range on 32bit mips, riku . voipio, 2011/06/20