[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2] Optimize screendump
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH v2] Optimize screendump |
Date: |
Mon, 20 Jun 2011 16:39:35 +0100 |
On Mon, Jun 20, 2011 at 9:12 AM, Avi Kivity <address@hidden> wrote:
> When running kvm-autotest, fputc() is often the second highest (sometimes #1)
> function showing up in a profile. This is due to fputc() locking the file
> for every byte written.
>
> Optimize by buffering a line's worth of pixels and writing that out in a
> single call.
>
> Signed-off-by: Avi Kivity <address@hidden>
> ---
>
> v2: drop unportable fputc_unlocked
>
> hw/vga.c | 13 ++++++++++---
> 1 files changed, 10 insertions(+), 3 deletions(-)
Reviewed-by: Stefan Hajnoczi <address@hidden>