[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 33/34] hw/usb-ohci.c: Implement remote wakeup
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH 33/34] hw/usb-ohci.c: Implement remote wakeup |
Date: |
Wed, 15 Jun 2011 16:03:27 +0100 |
On 14 June 2011 12:05, Gerd Hoffmann <address@hidden> wrote:
> From: Peter Maydell <address@hidden>
>
> Implement the wakeup callback in the OHCI USBPortOps, so that when
> a downstream device wakes up it correctly causes the OHCI controller
> to come out of suspend.
Just to let you know, this patch turns out to not be quite right:
* if the port is suspended and the controller is not, we need to
raise OHCI_INTR_RHSC
* if the controller is suspended we need to put it into the
resume state
* the controller can be suspended when the port is not, so the
check on s->ctl musn't be inside the port->ctrl if().
Sorry for the half-baked patch. I'll send a fixed version shortly.
-- PMM
- [Qemu-devel] [PULL] usb patch queue, Gerd Hoffmann, 2011/06/14
- [Qemu-devel] [PULL] usb patch queue, Gerd Hoffmann, 2011/06/24
- [Qemu-devel] [PATCH 03/13] usb-linux: track inflight iso urb count, Gerd Hoffmann, 2011/06/24
- [Qemu-devel] [PATCH 04/13] ehci: add freq + maxframes properties, Gerd Hoffmann, 2011/06/24
- [Qemu-devel] [PATCH 02/13] usb-linux: make iso urb count contigurable, Gerd Hoffmann, 2011/06/24
- [Qemu-devel] [PATCH 01/13] usb-linux: add get_endp(), Gerd Hoffmann, 2011/06/24
- [Qemu-devel] [PATCH 06/13] usb-bus: Don't allow attaching a device to a bus with no free ports, Gerd Hoffmann, 2011/06/24
- [Qemu-devel] [PATCH 05/13] ehci: switch to nanoseconds, Gerd Hoffmann, 2011/06/24
- [Qemu-devel] [PATCH 09/13] usb-linux: allow "compatible" high speed devices to connect at fullspeed, Gerd Hoffmann, 2011/06/24