[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/6] hw/9pfs: Add reference counting for fid
From: |
Aneesh Kumar K.V |
Subject: |
Re: [Qemu-devel] [PATCH 1/6] hw/9pfs: Add reference counting for fid |
Date: |
Fri, 10 Jun 2011 11:57:53 +0530 |
User-agent: |
Notmuch/0.5-215-g5143e5e (http://notmuchmail.org) Emacs/23.2.1 (i686-pc-linux-gnu) |
On Thu, 09 Jun 2011 16:10:39 -0700, Venkateswararao Jujjuri <address@hidden>
wrote:
> On 06/06/2011 10:16 AM, Aneesh Kumar K.V wrote:
> > Signed-off-by: Aneesh Kumar K.V<address@hidden>
>
> Just one minor issue below; otherwise
>
> Reviewed-by: Venkateswararao Jujjuri "<address@hidden>
>
> > ---
....
> > hw/9pfs/virtio-9p.c | 205
> > +++++++++++++++++++++++++++++++++++----------------
> >
> > pdu_unmarshal(pdu, offset, "dd",&fid,&datasync);
> > - fidp = lookup_fid(s, fid);
> > + fidp = get_fid(s, fid);
> > if (fidp == NULL) {
> > err = -ENOENT;
> > goto out;
> > @@ -1444,6 +1465,7 @@ static void v9fs_fsync(void *opaque)
> > err = offset;
> > }
> > out:
> > + put_fid(fidp);
> It should be
>
> put_fid(fidp);
>
> out_nofid:
>
ok
> > complete_pdu(s, pdu, err);
> > }
-aneesh
- Re: [Qemu-devel] [PATCH 5/6] hw/9pfs: Use v9fs_do_close instead of close, (continued)
- [Qemu-devel] [PATCH 4/6] hw/9pfs: init fid list properly, Aneesh Kumar K.V, 2011/06/06
- [Qemu-devel] [PATCH 2/6] hw/9pfs: Don't free fid in clunk, Aneesh Kumar K.V, 2011/06/06
- [Qemu-devel] [PATCH 6/6] hw/9pfs: Add directory reclaim support, Aneesh Kumar K.V, 2011/06/06
- [Qemu-devel] [PATCH 3/6] hw/9pfs: Add file descriptor reclaim support, Aneesh Kumar K.V, 2011/06/06
- Re: [Qemu-devel] [PATCH 1/6] hw/9pfs: Add reference counting for fid, Venkateswararao Jujjuri, 2011/06/09
- Re: [Qemu-devel] [PATCH 1/6] hw/9pfs: Add reference counting for fid,
Aneesh Kumar K.V <=