[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 21/31] usb-linux: Don't do perror when errno is not
From: |
Gerd Hoffmann |
Subject: |
[Qemu-devel] [PATCH 21/31] usb-linux: Don't do perror when errno is not set |
Date: |
Mon, 6 Jun 2011 14:39:12 +0200 |
From: Hans de Goede <address@hidden>
Note that "op" also is not set, so before this change these error paths
would feed NULL to perror.
Signed-off-by: Gerd Hoffmann <address@hidden>
---
usb-linux.c | 5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/usb-linux.c b/usb-linux.c
index 03e43c0..4c6c284 100644
--- a/usb-linux.c
+++ b/usb-linux.c
@@ -377,7 +377,8 @@ static int usb_host_claim_interfaces(USBHostDevice *dev,
int configuration)
i = 0;
dev_descr_len = dev->descr[0];
if (dev_descr_len > dev->descr_len) {
- goto fail;
+ fprintf(stderr, "husb: update iface failed. descr too short\n");
+ return 0;
}
i += dev_descr_len;
@@ -405,7 +406,7 @@ static int usb_host_claim_interfaces(USBHostDevice *dev,
int configuration)
if (i >= dev->descr_len) {
fprintf(stderr,
"husb: update iface failed. no matching configuration\n");
- goto fail;
+ return 0;
}
nb_interfaces = dev->descr[i + 4];
--
1.7.1
- [Qemu-devel] [PATCH 10/31] usb-ehci: fix error handling., (continued)
- [Qemu-devel] [PATCH 10/31] usb-ehci: fix error handling., Gerd Hoffmann, 2011/06/06
- [Qemu-devel] [PATCH 05/31] usb-ehci: improve mmio tracing, Gerd Hoffmann, 2011/06/06
- [Qemu-devel] [PATCH 08/31] usb-ehci: multiqueue support, Gerd Hoffmann, 2011/06/06
- [Qemu-devel] [PATCH 18/31] usb: documentation update, Gerd Hoffmann, 2011/06/06
- [Qemu-devel] [PATCH 19/31] usb-linux: Get speed from sysfs rather then from the connectinfo ioctl, Gerd Hoffmann, 2011/06/06
- [Qemu-devel] [PATCH 07/31] usb-ehci: add queue data struct, Gerd Hoffmann, 2011/06/06
- [Qemu-devel] [PATCH 23/31] usb-linux: Don't try to open the same device twice, Gerd Hoffmann, 2011/06/06
- [Qemu-devel] [PATCH 22/31] usb-linux: Ensure devep != 0, Gerd Hoffmann, 2011/06/06
- [Qemu-devel] [PATCH 21/31] usb-linux: Don't do perror when errno is not set,
Gerd Hoffmann <=
- [Qemu-devel] [PATCH 20/31] usb-linux: Teach about super speed, Gerd Hoffmann, 2011/06/06
- [Qemu-devel] [PATCH 16/31] usb-ehci: itd handling fixes., Gerd Hoffmann, 2011/06/06
- [Qemu-devel] [PATCH 25/31] usb: don't call usb_host_device_open from vl.c, Gerd Hoffmann, 2011/06/06
- [Qemu-devel] [PATCH 28/31] usb-bus: Don't detach non attached devices on device exit, Gerd Hoffmann, 2011/06/06
- [Qemu-devel] [PATCH 24/31] usb-linux: only cleanup in host_close when host_open was successful., Gerd Hoffmann, 2011/06/06
- [Qemu-devel] [PATCH 27/31] usb-bus: Add knowledge of USB_SPEED_SUPER to usb_speed helper, Gerd Hoffmann, 2011/06/06
- [Qemu-devel] [PATCH 26/31] usb-linux: Enlarge buffer for descriptors to 8192 bytes, Gerd Hoffmann, 2011/06/06
- [Qemu-devel] [PATCH 15/31] The USB tablet should not claim boot protocol support., Gerd Hoffmann, 2011/06/06
- [Qemu-devel] [PATCH 17/31] usb-ehci: split trace calls to handle arg count limits, Gerd Hoffmann, 2011/06/06
- [Qemu-devel] [PATCH 29/31] usb: Add defines for USB Serial Bus Release Number register, Gerd Hoffmann, 2011/06/06