[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH 01/13] Generic DMA memory access interface
From: |
Richard Henderson |
Subject: |
Re: [Qemu-devel] [RFC PATCH 01/13] Generic DMA memory access interface |
Date: |
Wed, 01 Jun 2011 08:16:44 -0700 |
User-agent: |
Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.17) Gecko/20110428 Fedora/3.1.10-1.fc15 Thunderbird/3.1.10 |
On 06/01/2011 07:29 AM, Avi Kivity wrote:
> On 06/01/2011 05:01 PM, Richard Henderson wrote:
>> > + err = dev->mmu->translate(dev, addr,&paddr,&plen, is_write);
>>
>> I see you didn't take my suggestion for using an opaque callback pointer.
>> Really and truly, I won't be able to use this as-is for Alpha.
>>
>
> Rather than opaques, please pass the DMA engine itself and use container_of().
The dma engine object is currently sitting in the PCIBus structure.
Which is private, and can't be extended by a host bridge implementation.
The entire code could be re-arranged, true, but please suggest something
reasonable.
> We should be removing opaques, not adding them.
See my followup elsewhere. Opaques *can* be cleaner than upcasting,
particularly if there are too many hoops through which to jump.
r~
- [Qemu-devel] [RFC PATCH 00/13] AMD IOMMU emulation patches, another try, Eduard - Gabriel Munteanu, 2011/06/01
- [Qemu-devel] [RFC PATCH 02/13] pci: add IOMMU support via the generic DMA layer, Eduard - Gabriel Munteanu, 2011/06/01
- [Qemu-devel] [RFC PATCH 03/13] AMD IOMMU emulation, Eduard - Gabriel Munteanu, 2011/06/01
- [Qemu-devel] [RFC PATCH 01/13] Generic DMA memory access interface, Eduard - Gabriel Munteanu, 2011/06/01
- Re: [Qemu-devel] [RFC PATCH 01/13] Generic DMA memory access interface, Eduard - Gabriel Munteanu, 2011/06/01
- Re: [Qemu-devel] [RFC PATCH 01/13] Generic DMA memory access interface, Richard Henderson, 2011/06/01
- Re: [Qemu-devel] [RFC PATCH 01/13] Generic DMA memory access interface, Eduard - Gabriel Munteanu, 2011/06/01
- Re: [Qemu-devel] [RFC PATCH 01/13] Generic DMA memory access interface, Richard Henderson, 2011/06/01
- Re: [Qemu-devel] [RFC PATCH 01/13] Generic DMA memory access interface, David Gibson, 2011/06/02
[Qemu-devel] [RFC PATCH 04/13] ide: use the DMA memory access interface for PCI IDE controllers, Eduard - Gabriel Munteanu, 2011/06/01
[Qemu-devel] [RFC PATCH 05/13] rtl8139: use the DMA memory access interface, Eduard - Gabriel Munteanu, 2011/06/01
[Qemu-devel] [RFC PATCH 06/13] eepro100: use the DMA memory access interface, Eduard - Gabriel Munteanu, 2011/06/01
[Qemu-devel] [RFC PATCH 07/13] ac97: use the DMA memory access interface, Eduard - Gabriel Munteanu, 2011/06/01