[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 13/14] usb-bus: Don't detach non attached devices on
From: |
Hans de Goede |
Subject: |
[Qemu-devel] [PATCH 13/14] usb-bus: Don't detach non attached devices on device exit |
Date: |
Tue, 31 May 2011 11:35:29 +0200 |
This causes an "Error: tried to detach unattached usb device " to be printed,
this can happen when deleting ie a usb host qdev, which did not
get attached (because a device matching the filter never got plugged in).
---
hw/usb-bus.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/hw/usb-bus.c b/hw/usb-bus.c
index bb040d2..0a49921 100644
--- a/hw/usb-bus.c
+++ b/hw/usb-bus.c
@@ -84,7 +84,9 @@ static int usb_qdev_exit(DeviceState *qdev)
USBDevice *dev = DO_UPCAST(USBDevice, qdev, qdev);
USBBus *bus = usb_bus_from_device(dev);
- usb_device_detach(dev);
+ if (dev->attached) {
+ usb_device_detach(dev);
+ }
bus->ops->device_destroy(bus, dev);
if (dev->info->handle_destroy) {
dev->info->handle_destroy(dev);
--
1.7.5.1
- [Qemu-devel] [PATCH 09/14] usb-linux: Don't declare a usbdevice_name, (continued)
- [Qemu-devel] [PATCH 09/14] usb-linux: Don't declare a usbdevice_name, Hans de Goede, 2011/05/31
- [Qemu-devel] [PATCH 11/14] usb-bus: Add knowledge of USB_SPEED_SUPER to usb_speed helper, Hans de Goede, 2011/05/31
- [Qemu-devel] [PATCH 12/14] usb-bus: Don't allow attaching a device to a bus with no free ports, Hans de Goede, 2011/05/31
- [Qemu-devel] [PATCH 14/14] usb: Proper error propagation for usb_device_attach errors, Hans de Goede, 2011/05/31
- Re: [Qemu-devel] [PATCH 14/14] usb: Proper error propagation for usb_device_attach errors, Michael Tokarev, 2011/05/31
- Re: [Qemu-devel] [PATCH 14/14] usb: Proper error propagation for usb_device_attach errors, Hans de Goede, 2011/05/31
- Re: [Qemu-devel] [PATCH 14/14] usb: Proper error propagation for usb_device_attach errors, Kevin Wolf, 2011/05/31
- Re: [Qemu-devel] [PATCH 14/14] usb: Proper error propagation for usb_device_attach errors, Hans de Goede, 2011/05/31
- Re: [Qemu-devel] [PATCH 14/14] usb: Proper error propagation for usb_device_attach errors, Kevin Wolf, 2011/05/31
- Re: [Qemu-devel] [PATCH 14/14] usb: Proper error propagation for usb_device_attach errors, Hans de Goede, 2011/05/31
[Qemu-devel] [PATCH 13/14] usb-bus: Don't detach non attached devices on device exit,
Hans de Goede <=