Re: [Qemu-devel] [PATCH] Buildfix: fix libcacard build with -m32 on 64bit machine

[Alon Levy]

On Thu, May 26, 2011 at 01:56:54PM -0400, Stefan Berger wrote:
> When configuring with --extra-cflags="-m32" on a 64bit machine the
> following error appears during compilation:

Thanks for the fix.

Reviewed-by: Alon Levy <address@hidden>

> 
> make  -C libhw64 V="1" TARGET_DIR="libhw64/" all
> make[1]: Entering directory `/root/tmp/qemu-git/libhw64'
> make[1]: Leaving directory `/root/tmp/qemu-git/libhw64'
> make  -C libcacard V="1" TARGET_DIR="libcacard/" all
> make[1]: Entering directory `/root/tmp/qemu-git/libcacard'
> gcc -lssl3 -lsmime3 -lnss3 -lnssutil3 -lplds4 -lplc4 -lnspr4
> -lpthread -ldl   -lrt -o vscclient cac.o event.o vcard.o vreader.o
> vcard_emul_nss.o vcard_emul_type.o card_7816.o ../osdep.o
> ../oslib-posix.o ../qemu-thread-posix.o ../trace.o ../qemu-malloc.o
> ../qemu-timer-common.o vscclient.o
> cac.o: could not read symbols: File in wrong format
> collect2: ld returned 1 exit status
> make[1]: *** [vscclient] Error 1
> make[1]: Leaving directory `/root/tmp/qemu-git/libcacard'
> make: *** [subdir-libcacard] Error 2
> 
> The LDFLAGS are not passed to the compiled. The below patch fixes it.
> 
> Signed-off-by: Stefan Berger <address@hidden>
> 
> ---
>  libcacard/Makefile |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Index: qemu-git/libcacard/Makefile
> ===================================================================
> --- qemu-git.orig/libcacard/Makefile
> +++ qemu-git/libcacard/Makefile
> @@ -9,7 +9,7 @@ QEMU_OBJS=$(addprefix ../, $(oslib-obj-y
>  QEMU_CFLAGS+=-I../
> 
>  vscclient: $(libcacard-y) $(QEMU_OBJS) vscclient.o
> -    $(call quiet-command,$(CC) $(libcacard_libs) -lrt -o $@ $^,"
> LINK  $(TARGET_DIR)$@")
> +    $(call quiet-command,$(CC) $(LDFLAGS) $(libcacard_libs) -lrt -o
> $@ $^,"  LINK  $(TARGET_DIR)$@")
> 
>  all: vscclient
> 
>