[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [RFCv2] vga: VBE: report maximum VGA_MEM_SIZE memory
From: |
Alon Levy |
Subject: |
[Qemu-devel] [RFCv2] vga: VBE: report maximum VGA_MEM_SIZE memory |
Date: |
Wed, 25 May 2011 18:56:05 +0300 |
When using -vga qxl the amount reported is minimally 32 MiB, making windows
guests come up in a 16 color mode. With this change they work correctly, coming
up with the full range of VBE supported modes.
This patch changes just the reported memory size by VBE
(VBE_DISPI_INDEX_VIDEO_MEMORY_64K) and not the actual vram_size like my
previous try.
---
hw/vga.c | 9 ++++++++-
1 files changed, 8 insertions(+), 1 deletions(-)
diff --git a/hw/vga.c b/hw/vga.c
index 124295a..07048bc 100644
--- a/hw/vga.c
+++ b/hw/vga.c
@@ -545,7 +545,14 @@ static uint32_t vbe_ioport_read_data(void *opaque,
uint32_t addr)
val = s->vbe_regs[s->vbe_index];
}
} else if (s->vbe_index == VBE_DISPI_INDEX_VIDEO_MEMORY_64K) {
- val = s->vram_size / (64 * 1024);
+ /*
+ * windows xp guests don't like larger then VGA_RAM_SIZE (8 MiB),
+ * wrongly setting the display to 4 bit color depth. This fix doesn't
+ * affect native mode, where we have modes that require larger amounts
+ * of ram. (The maximum that VBE reports is 1600x1200 32 bit color depth
+ * which fits)
+ */
+ val = MIN(VGA_RAM_SIZE, s->vram_size) / (64 * 1024);
} else {
val = 0;
}
--
1.7.5.1
- [Qemu-devel] [RFCv2] vga: VBE: report maximum VGA_MEM_SIZE memory,
Alon Levy <=