[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/6] Add TCG optimizations stub
From: |
Richard Henderson |
Subject: |
Re: [Qemu-devel] [PATCH 1/6] Add TCG optimizations stub |
Date: |
Fri, 20 May 2011 11:33:37 -0700 |
User-agent: |
Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.17) Gecko/20110428 Fedora/3.1.10-1.fc14 Thunderbird/3.1.10 |
On 05/20/2011 11:12 AM, Richard Henderson wrote:
> On 05/20/2011 05:39 AM, Kirill Batuzov wrote:
>> + i = (op == INDEX_op_call) ?
>> + (args[0] >> 16) + (args[0] & 0xffff) + 3 :
>> + def->nb_args;
>> + while (i) {
>> + *gen_args = *args;
>> + args++;
>> + gen_args++;
>> + i--;
>> + }
>
> If you use the correct NOP, i.e. nop vs nop[123n], then
> I don't believe you need to compact the arguments like this.
Bah, nevermind. I forgot that we'd have to do something else
odd to replace n-operand operation opcodes with 2-operand movi.
I went back and saw Aurelien did this with a memmove in his
patch; it's probably more efficient to move pieces at a time
to fill in holes, as you do here.
r~
- [Qemu-devel] [PATCH 0/6] Implement constant folding and copy propagation in TCG, Kirill Batuzov, 2011/05/20
- [Qemu-devel] [PATCH 1/6] Add TCG optimizations stub, Kirill Batuzov, 2011/05/20
- [Qemu-devel] [PATCH 6/6] Do constant folding for unary operations., Kirill Batuzov, 2011/05/20
- [Qemu-devel] [PATCH 5/6] Do constant folding for shift operations., Kirill Batuzov, 2011/05/20
- Re: [Qemu-devel] [PATCH 5/6] Do constant folding for shift operations., Richard Henderson, 2011/05/20
- Re: [Qemu-devel] [PATCH 5/6] Do constant folding for shift operations., Kirill Batuzov, 2011/05/26
- Re: [Qemu-devel] [PATCH 5/6] Do constant folding for shift operations., Richard Henderson, 2011/05/26
- Re: [Qemu-devel] [PATCH 5/6] Do constant folding for shift operations., Blue Swirl, 2011/05/26
- Re: [Qemu-devel] [PATCH 5/6] Do constant folding for shift operations., Richard Henderson, 2011/05/26
- Re: [Qemu-devel] [PATCH 5/6] Do constant folding for shift operations., Blue Swirl, 2011/05/26
- Re: [Qemu-devel] [PATCH 5/6] Do constant folding for shift operations., Richard Henderson, 2011/05/26