|
| From: | Paolo Bonzini |
| Subject: | Re: [Qemu-devel] [PATCH v4 1/3] coroutine: introduce coroutines |
| Date: | Fri, 20 May 2011 14:09:13 +0200 |
| User-agent: | Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.17) Gecko/20110428 Fedora/3.1.10-1.fc14 Lightning/1.0b3pre Mnenhy/0.8.3 Thunderbird/3.1.10 |
On 05/20/2011 12:59 PM, Stefan Hajnoczi wrote:
This coroutines implementation is based on the gtk-vnc implementation written by Anthony Liguori<address@hidden> but it has been significantly rewritten by Kevin Wolf<address@hidden> to use setjmp()/longjmp() instead of the more expensive swapcontext() and by Paolo Bonzini<address@hidden> for Windows Fibers support.
Not a blocker at all, but why did you move the pooling to the ucontext implementation? It's less expensive to create the fiber in Windows because there are no system calls (unlike swapcontext), but a future pthread-based implementation will also need the pooling.
It can be left to whoever writes the pthread stuff, though. Paolo
| [Prev in Thread] | Current Thread | [Next in Thread] |