Re: [Qemu-devel] [PATCH] xen: Use conditional compilation for xen map cache (fixes w32 builds)

[Stefano Stabellini]

On Thu, 19 May 2011, Alexander Graf wrote:
> On 05/18/2011 08:27 PM, Stefano Stabellini wrote:
> > On Wed, 18 May 2011, Stefan Weil wrote:
> >> The current implementation used stubs for systems without XEN.
> >> This is unusual for QEMU and adds unneeded dependencies.
> >>
> >> MinGW32 for example does not provide munmap(), so the XEN
> >> code creates compiler warnings (missing prototype).
> >> Compilations without optimisation even result in linker
> >> errors (missing function).
> >>
> >> Fix this by using conditional compilation.
> > After a conversation on IRC with Stefan I found out that most of the
> > problems are gone away after my recent "xen mapcache fixes and
> > improvements" patch series.
> >
> > To completely solve the compilation issues with MinGW32 I just need to
> > remove two includes from xen-mapcache.h, so I am appending an updated
> > version of patch #3 "xen: remove xen_map_block and xen_unmap_block" to
> > do just that.
> >
> > I have also pushed another git branch:
> >
> > git://xenbits.xen.org/people/sstabellini/qemu-dm.git mapcache_fixes_2
> 
> So please resend v2 to the ML. From my POV the patches look ok, but I'd 
> like to give others some more chance of commenting on them.

Ok, I'll do that.