[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] ahci: Fix non-NCQ accesses for LBA > 16bits
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-devel] [PATCH] ahci: Fix non-NCQ accesses for LBA > 16bits |
Date: |
Thu, 19 May 2011 12:09:35 +0200 |
User-agent: |
Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.15) Gecko/20101027 Fedora/3.0.10-1.fc12 Thunderbird/3.0.10 |
Am 19.05.2011 11:57, schrieb Alexander Graf:
> AHCI provides two ways of reading/writing data:
>
> 1) NCQ
> 2) ATA commands with the LBA in the command FIS
>
> In the second code path, we didn't handle any LBAs that were bigger than
> 16 bits, so whenever a guest that used high LBA numbers wanted to access
> data, the LBA got truncated down to 16 bits, giving the guest garbage.
>
> This patch adds support for LBAs higher than 16 bits. I've tested that it
> works just fine with SeaBIOS and Linux guests. This patch also unbreaks
> the often reported grub errors people have seen with AHCI.
>
> Signed-off-by: Alexander Graf <address@hidden>
>
> ---
>
> v1 -> v2:
>
> - document fis bytes
Thanks, applied to the block branch.
Kevin