[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [V2 05/25] [virtio-9p] Move errno into v9fs_do_readlink
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [V2 05/25] [virtio-9p] Move errno into v9fs_do_readlink |
Date: |
Wed, 18 May 2011 10:31:18 +0100 |
On Tue, May 17, 2011 at 8:43 PM, Venkateswararao Jujjuri (JV)
<address@hidden> wrote:
> Signed-off-by: Venkateswararao Jujjuri "<address@hidden>
> ---
> hw/9pfs/virtio-9p.c | 32 ++++++++++++++++----------------
> 1 files changed, 16 insertions(+), 16 deletions(-)
Please see my comment from v1:
"The len argument is redundant and not used by any callers, please just
return -errno and drop the len argument. Callers rely on buf->size
instead."
Stefan
- [Qemu-devel] [V2 0/25] Async threading for VirtFS using glib threads & coroutines., Venkateswararao Jujjuri (JV), 2011/05/17
- [Qemu-devel] [V2 05/25] [virtio-9p] Move errno into v9fs_do_readlink, Venkateswararao Jujjuri (JV), 2011/05/17
- Re: [Qemu-devel] [V2 05/25] [virtio-9p] Move errno into v9fs_do_readlink,
Stefan Hajnoczi <=
- [Qemu-devel] [V2 03/25] [virtio-9p] Remove post functions for v9fs_readlink., Venkateswararao Jujjuri (JV), 2011/05/17
- [Qemu-devel] [V2 09/25] hw/9pfs: Add yield support for readdir related coroutines, Venkateswararao Jujjuri (JV), 2011/05/17
- [Qemu-devel] [V2 12/25] hw/9pfs: Update v9fs_statfs to use coroutines, Venkateswararao Jujjuri (JV), 2011/05/17
- [Qemu-devel] [V2 14/25] hw/9pfs: Update v9fs_getattr to use coroutines, Venkateswararao Jujjuri (JV), 2011/05/17
- [Qemu-devel] [V2 08/25] [virtio-9p] clean up v9fs_mkdir., Venkateswararao Jujjuri (JV), 2011/05/17
- [Qemu-devel] [V2 11/25] hw/9pfs: Add yield support to statfs coroutine, Venkateswararao Jujjuri (JV), 2011/05/17
- [Qemu-devel] [V2 16/25] hw/9pfs: Update v9fs_setattr to use coroutines, Venkateswararao Jujjuri (JV), 2011/05/17