Re: [Qemu-devel] [PATCH] target-lm32: Remove unused local variables

[Aurelien Jarno]

On Sat, May 07, 2011 at 10:49:33PM +0200, Stefan Weil wrote:
> cppcheck report:
> target-lm32/translate.c:587: style:
>     Variable 't0' is assigned a value that is never used
> target-lm32/translate.c:588: style:
>     Variable 'l1' is assigned a value that is never used
> 
> Remove both variables. Please check whether that is the correct solution.
> 
> Cc: Michael Walle <address@hidden>
> Cc: Edgar E. Iglesias <address@hidden>
> Signed-off-by: Stefan Weil <address@hidden>
> ---
>  target-lm32/translate.c |    6 ------
>  1 files changed, 0 insertions(+), 6 deletions(-)

Thanks, applied.

> diff --git a/target-lm32/translate.c b/target-lm32/translate.c
> index bcd52fe..eb21158 100644
> --- a/target-lm32/translate.c
> +++ b/target-lm32/translate.c
> @@ -584,9 +584,6 @@ static void dec_orhi(DisasContext *dc)
>  
>  static void dec_scall(DisasContext *dc)
>  {
> -    TCGv t0;
> -    int l1;
> -
>      if (dc->imm5 == 7) {
>          LOG_DIS("scall\n");
>      } else if (dc->imm5 == 2) {
> @@ -595,9 +592,6 @@ static void dec_scall(DisasContext *dc)
>          cpu_abort(dc->env, "invalid opcode\n");
>      }
>  
> -    t0 = tcg_temp_new();
> -    l1 = gen_new_label();
> -
>      if (dc->imm5 == 7) {
>          tcg_gen_movi_tl(cpu_pc, dc->pc);
>          t_gen_raise_exception(dc, EXCP_SYSTEMCALL);
> -- 
> 1.7.2.5
> 
> 
> 

-- 
Aurelien Jarno                          GPG: 1024D/F1BCDB73
address@hidden                 http://www.aurel32.net