Re: [Qemu-devel] [PATCH 05/25] [virtio-9p] Move errno into v9fs_do_readlink

[Stefan Hajnoczi]

On Thu, May 12, 2011 at 01:57:27PM -0700, Venkateswararao Jujjuri (JV) wrote:
> Signed-off-by: Venkateswararao Jujjuri "<address@hidden>
> ---
>  hw/9pfs/virtio-9p.c |   32 ++++++++++++++++----------------
>  1 files changed, 16 insertions(+), 16 deletions(-)
> 
> diff --git a/hw/9pfs/virtio-9p.c b/hw/9pfs/virtio-9p.c
> index c4d903a..a748c34 100644
> --- a/hw/9pfs/virtio-9p.c
> +++ b/hw/9pfs/virtio-9p.c
> @@ -82,19 +82,21 @@ static int v9fs_do_lstat(V9fsState *s, V9fsString *path, 
> struct stat *stbuf)
>      return s->ops->lstat(&s->ctx, path->data, stbuf);
>  }
>  
> -static ssize_t v9fs_do_readlink(V9fsState *s, V9fsString *path, V9fsString 
> *buf)
> +static int v9fs_do_readlink(V9fsState *s, V9fsString *path, V9fsString *buf,
> +        ssize_t *len)

The len argument is redundant and not used by any callers, please just
return -errno and drop the len argument.  Callers rely on buf->size
instead.

Stefan