[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 0/5] Split ide-drive and scsi-disk qdevs, and
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-devel] [PATCH v2 0/5] Split ide-drive and scsi-disk qdevs, and more |
Date: |
Tue, 10 May 2011 13:39:12 +0200 |
User-agent: |
Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.15) Gecko/20101027 Fedora/3.0.10-1.fc12 Thunderbird/3.0.10 |
Am 09.05.2011 11:51, schrieb Markus Armbruster:
> This patch series is about purging the "type hint" from the block
> layer. My previous series cleaned up improper uses it. Remaining
> uses are info block and qdevs ide-drive, scsi-disk.
>
> ide-drive and scsi-disk can either act as disk or as CD drive. They
> use their drive's type hint to decide between disk and CD. This is
> unclean. Disk vs. CD needs to be in qdev, not BlockDriverState,
> because it belongs to the drive's guest part.
>
> Split them into separate devices for disk and CD. Keep the old ones
> for backward compatibility.
>
> Remove the type hint from info block. Its value is unreliable anyway.
> libvirt doesn't use it.
>
> I posted v1 quite some time ago. Since we were working towards a
> release then, we decided to take only the bonus bug fixes (PATCH 1-3),
> and revisit the rest later. Which has turned out to be "somewhat"
> later than anticpiated. Sorry about that.
Thanks, applied to the block branch.
Kevin
- [Qemu-devel] [PATCH v2 0/5] Split ide-drive and scsi-disk qdevs, and more, Markus Armbruster, 2011/05/09
- [Qemu-devel] [PATCH v2 3/5] block QMP: Drop query-block member "type" (type= in info block), Markus Armbruster, 2011/05/09
- [Qemu-devel] [PATCH v2 5/5] block: Remove type hint, it's guest matter, doesn't belong here, Markus Armbruster, 2011/05/09
- [Qemu-devel] [PATCH v2 4/5] blockdev: Store -drive option media in DriveInfo, Markus Armbruster, 2011/05/09
- [Qemu-devel] [PATCH v2 2/5] scsi: Split qdev "scsi-disk" into "scsi-hd" and "scsi-cd", Markus Armbruster, 2011/05/09
- [Qemu-devel] [PATCH v2 1/5] ide: Split qdev "ide-drive" into "ide-hd" and "ide-cd", Markus Armbruster, 2011/05/09
- Re: [Qemu-devel] [PATCH v2 0/5] Split ide-drive and scsi-disk qdevs, and more, Gerd Hoffmann, 2011/05/09
- Re: [Qemu-devel] [PATCH v2 0/5] Split ide-drive and scsi-disk qdevs, and more,
Kevin Wolf <=
- [Qemu-devel] [PATCH v2 0/5] Split ide-drive and scsi-disk qdevs, and more, Markus Armbruster, 2011/05/12
- [Qemu-devel] [PATCH v3 4/6] blockdev: Store -drive option media in DriveInfo, Markus Armbruster, 2011/05/12
- [Qemu-devel] [PATCH v3 5/6] block: Remove type hint, it's guest matter, doesn't belong here, Markus Armbruster, 2011/05/12
- [Qemu-devel] [PATCH v3 6/6] defaults: ide-cd and scsi-cd devices suppress default CD-ROM, Markus Armbruster, 2011/05/12
- [Qemu-devel] [PATCH v3 3/6] block QMP: Drop query-block member "type" (type= in info block), Markus Armbruster, 2011/05/12