[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH V4 01/10] Support for TPM command line options
From: |
Serge E. Hallyn |
Subject: |
Re: [Qemu-devel] [PATCH V4 01/10] Support for TPM command line options |
Date: |
Fri, 6 May 2011 15:23:32 -0500 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Quoting Stefan Berger (address@hidden):
> This patch adds support for TPM command line options.
> The command line supported here (considering the libtpms based
> backend) are
>
> ./qemu-... -tpm type=<type>,path=<path to blockstorage file>,
>
> and
>
> ./qemu-... -tpm ?
>
> where the latter works similar to -soundhw ? and shows a list of
> available TPM backends (i.e., libtpms-based, Xen).
>
> Only the 'type' is interpreted in arch_init.c. Using this parameter,
> the backend is chosen, i.e., 'builtin' for the libtpms-based
> builtin TPM. The interpretation of the other parameters along with
> determining whether enough parameters were provided is pushed into
> the backend driver, which needs to implement the interface function
> 'handle_options' and return true if the VM can be started or 'false'
> if not enough or bad parameters were provided.
>
> v4:
> - coding style fixes
>
> v3:
> - added hw/tpm_tis.h to this patch so Qemu compiles at this stage
>
> Signed-off-by: Stefan Berger <address@hidden>
Thanks, Stefan. Two nits:
> +static QemuOptsList qemu_tpm_opts = {
> + .name = "tpm",
> + .head = QTAILQ_HEAD_INITIALIZER(qemu_tpm_opts.head),
> + .desc = {
> + {
> + .name = "type",
> + .type = QEMU_OPT_STRING,
> + .help = "Type of TPM backend",
> + },
> + {
> + .name = "path",
> + .type = QEMU_OPT_STRING,
> + .help = "Persitent storage for TPM state",
Persistent.
...
> +# else /* CONFIG_TPM */
> +
> +void select_tpm(const char *optarg)
> +{
> + (void)optarg;
> +}
I realize this should never get called if !CONFIG_TPM, but that still
doesn't seem like cause to go directly calling a potentially NULL
string.
Otherwise, fwiw
Acked-by: Serge Hallyn <address@hidden>
thanks,
-serge
- [Qemu-devel] [PATCH V4 10/10] Encrypt state blobs using AES CBC encryption, (continued)
- [Qemu-devel] [PATCH V4 10/10] Encrypt state blobs using AES CBC encryption, Stefan Berger, 2011/05/06
- [Qemu-devel] [PATCH V4 09/10] Add block storage support for libtpms based TPM backend, Stefan Berger, 2011/05/06
- [Qemu-devel] [PATCH V4 03/10] Add persistent state handling to TPM TIS frontend driver, Stefan Berger, 2011/05/06
- [Qemu-devel] [PATCH V4 08/10] Introduce file lock for the block layer, Stefan Berger, 2011/05/06
- [Qemu-devel] [PATCH V4 05/10] Add a debug register, Stefan Berger, 2011/05/06
- [Qemu-devel] [PATCH V4 07/10] Implementation of the libtpms-based backend, Stefan Berger, 2011/05/06
- [Qemu-devel] [PATCH V4 01/10] Support for TPM command line options, Stefan Berger, 2011/05/06
- Re: [Qemu-devel] [PATCH V4 01/10] Support for TPM command line options,
Serge E. Hallyn <=
- Re: [Qemu-devel] [PATCH V4 01/10] Support for TPM command line options, Serge E. Hallyn, 2011/05/17
- Re: [Qemu-devel] [PATCH V4 01/10] Support for TPM command line options, Stefan Berger, 2011/05/17
[Qemu-devel] [PATCH V4 06/10] Add a TPM backend skeleton implementation, Stefan Berger, 2011/05/06
[Qemu-devel] [PATCH V4 02/10] Add TPM (frontend) hardware interface (TPM TIS) to Qemu, Stefan Berger, 2011/05/06